bump go to 1.22, k8s deps to 0.30.0 #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everettraven
commented
May 16, 2024
everettraven
commented
May 16, 2024
Comment on lines
+150
to
+151
| var obj client.Object = evt.Object | ||
| if obj == nil { |
There was a problem hiding this comment.
This was needed to maintain the existing expectations of the API where a nil object in the event would result in returning a default filter value
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 88.71% 88.88% +0.17%
==========================================
Files 17 18 +1
Lines 567 576 +9
==========================================
+ Hits 503 512 +9
Misses 51 51
Partials 13 13 ☔ View full report in Codecov by Sentry. |
Signed-off-by: everettraven <everettraven@gmail.com>
b6409b8 to
4d3d4c4
Compare
|
Squashed commits |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
handlerpackage so that handlers satisfy the updated controller-runtime APIs that use genericsMotivation for the change: