Skip to content

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jun 20, 2024

Description of the change:

  • functionalities param is no longer exist. It was used to enable file fixes to ignore common lines from coverage. This feature is now seems to be on by default.

  • Adding disable_search because we do not need for the codecov action to search for coverage files: we explicitly provide files.

Motivation for the change:

Fixing codecov config

* `functionalities` param is no longer exist.
  It was used to enable file fixes to ignore common lines from coverage.
  This feature is now seems to be on by default.

* Adding `disable_search` because we do not need for the codecov action
  to search for coverage files: we explicitly provide files.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola requested a review from a team as a code owner June 20, 2024 09:42
@openshift-ci openshift-ci bot requested review from everettraven and jmrodri June 20, 2024 09:42
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (bf5fa88) to head (8d943c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files          18       18           
  Lines         576      576           
=======================================
  Hits          512      512           
  Misses         51       51           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@everettraven everettraven added this pull request to the merge queue Jun 21, 2024
Merged via the queue into operator-framework:main with commit 06c5e6d Jun 21, 2024
@m1kola m1kola deleted the codecov_fixes branch June 24, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants