Skip to content

Conversation

perdasilva
Copy link
Contributor

Description of the change:

Motivation for the change:

@perdasilva perdasilva requested a review from a team as a code owner August 29, 2024 10:06
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (61b7e14) to head (97ab4fb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files          18       18           
  Lines         699      699           
=======================================
  Hits          619      619           
  Misses         67       67           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@grokspawn
Copy link

@perdasilva rebase?

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva changed the title 🌱 Bump go to v1.23.0 🌱 Bump go to v1.23 Jan 9, 2025
@perdasilva perdasilva changed the title 🌱 Bump go to v1.23 🌱 Bump to go1.23 Jan 9, 2025
@acornett21
Copy link
Contributor

The lint version needs to be updated to v1.62.2 or higher.

Per Goncalves da Silva added 3 commits January 9, 2025 17:00
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@camilamacedo86
Copy link
Contributor

/lgtm cancel

@perdasilva

You will need to fix predicate/predicate_suite_test.go:37:30 revive redefines-builtin-id: redefinition of the built-in function new :-(

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva added this pull request to the merge queue Jan 13, 2025
Merged via the queue into operator-framework:main with commit be2540b Jan 13, 2025
6 checks passed
@perdasilva perdasilva deleted the perdasilva/bump/go branch January 13, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants