Skip to content

feat(attribute_value): Don't target NaN, infinity and value greater than 2^53. #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(attribute_value): Don't target NaN, infinity and value greater than 2^53. #119

wants to merge 1 commit into from

Conversation

mfahadahmed
Copy link
Contributor

@mfahadahmed mfahadahmed commented Dec 20, 2018 •
edited
Loading

Summary

Don't target NaN, infinity doubles or numeric values greater than 2^53 in Evaluators.

Test plan

Issues

  • OASIS-3657

@mfahadahmed
Copy link
Contributor Author

Closing it as the required validation has already been done in this PR: #121

@mfahadahmed mfahadahmed deleted the fahad/dont-target-invalid-numeric-value branch January 11, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfahadahmed @msohailhussain