Skip to content

added disposed and max wait time. #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2020
Merged

added disposed and max wait time. #231

merged 1 commit into from
Jul 7, 2020

Conversation

msohailhussain
Copy link
Contributor

Summary

  • Called Dispose method on every HttpConfigManager instance after test, Problem was Continuous polling of older instances were called for new mocked instance which is why test cases were being failed.
  • Added maximum wait time to avoid deadlock or stale situation, OnReady wait until gets resolved, if no valid Config is provided, it remains unresolved which causes deadlock.

Test plan

  • All unit test must pass.

@msohailhussain msohailhussain marked this pull request as ready for review July 7, 2020 19:09
@msohailhussain msohailhussain requested a review from a team as a code owner July 7, 2020 19:09
@msohailhussain msohailhussain removed their assignment Jul 7, 2020
@msohailhussain msohailhussain reopened this Jul 7, 2020
@msohailhussain msohailhussain removed their assignment Jul 7, 2020
@msohailhussain msohailhussain reopened this Jul 7, 2020
@msohailhussain msohailhussain removed their assignment Jul 7, 2020
mikeproeng37
mikeproeng37 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit c49e858 into master Jul 7, 2020
@mikeproeng37 mikeproeng37 deleted the sohail/fixflakyunittests branch July 7, 2020 22:01
jaeopt pushed a commit that referenced this pull request Jul 7, 2020
@msohailhussain @jaeopt
added disposed and max wait time. (#231)
efc0183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msohailhussain @mikeproeng37