Feature Flag & Roll out models #25
Conversation
Datafile parsing & Validation Travis Issue fixed (mono specific version for unit testing)
|
Can one of the admins verify this patch? |
|
@asaschachar Can you please assign reviewer. JIRA tickets OASIS-1942 and OASIS-1943 are covered. OASIS-1948 and OASIS-1949 are covered. |
| @@ -51,7 +51,7 @@ public void Setup() | |||
| public void TestInit() | |||
| { | |||
| // Check Version | |||
| Assert.AreEqual(2, Config.Version); | |||
There was a problem hiding this comment.
Until we GA feature flags, we need to support BOTH datafile v2 and datafile v4.
There was a problem hiding this comment.
Nah because we can keep this in the master branch and deploy from the 1.2.x branch of we need to do so before FF GA.
|
|
||
| namespace OptimizelySDK.Entity | ||
| { | ||
| public class FeatureVariableUsage : IdKeyEntity |
There was a problem hiding this comment.
This should have a value prop
|
|
||
| // Check Variation ID Map | ||
| var variationIdMap = new Dictionary<string, object> | ||
| var expectedVariationIdMap = new Dictionary<string, object> |
There was a problem hiding this comment.
Can you generate some variable usages within variations of one of the experiment and assert that the FeatureVariableUsageInstance maps are generated properly for those variations.
|
@mikeng13 Thanks for pointing out variable usage test case, it was the issue in the SDK, was not deserializing variables in variation. Fixed it here. |
|
@msohailhussain I ran our E2E test suite and the testapp build failed with this error: |
|
@mikeng13 sorry about it, let me investigate. |
|
@mikeng13 Fixed it, We manually add files in .netstandard project, and it missed 'closed' markup. |
Feature Notification Center
* Feature Notification Center (#25) * Added FeatureExperiment and FeatureRollout notification types. * Fixed code review defects. * TestBucketLogsCorrectlyWhenUserProfileFailsToSave fixed. Added one more test case for FeatureRollout Notification type. Removed ConfigParser method which was not being used. * remvoed feature experiment and featurue rollout notifications. * removed feature experiment and feature rollback callbacks. * fixed unit test issue.
Datafile parsing & Validation
Travis Issue fixed (set mono specific version for unit testing)