Skip to content

Feat: Added unit test to verify in which SendFlagDecision is true and false #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2021
Merged

Feat: Added unit test to verify in which SendFlagDecision is true and false #258

merged 3 commits into from
Feb 12, 2021

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Feb 1, 2021

Summary

  • Added unit tests to verify when source type is rollout and SendFlagDecisions is false then event should not dispatch and decisionEventDispatched should be false.
  • Added unit tests to verify when source type is rollout and SendFlagDecisions is true then event should dispatch and decisionEventDispatched should be true.

@mnoman09 mnoman09 requested a review from a team as a code owner February 1, 2021 10:37
jaeopt
jaeopt requested changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good.
Suggested to add the same tests for featureTest as well.

OptimizelySDK.Tests/OptimizelyTest.cs Outdated
var featureKey = "boolean_single_variable_feature";
var featureFlag = Config.GetFeatureFlagFromKey(featureKey);
var variables = Optimizely.GetAllFeatureVariables(featureKey, TestUserId);
var reasons = new OptimizelyDecideOption[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

OptimizelySDK.Tests/OptimizelyTest.cs Outdated
var featureKey = "boolean_single_variable_feature";
var featureFlag = Config.GetFeatureFlagFromKey(featureKey);
var variables = Optimizely.GetAllFeatureVariables(featureKey, TestUserId);
var reasons = new OptimizelyDecideOption[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

OptimizelySDK.Tests/OptimizelyTest.cs
{ "ruleKey", ruleKey },
{ "reasons", reasons },
{ "decisionEventDispatched", false }
}))), Times.Once);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you validation that event is actually not sent out?

OptimizelySDK.Tests/OptimizelyTest.cs
{ "reasons", reasons },
{ "decisionEventDispatched", true }
}))), Times.Once);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you validation that event is actually sent out and event contents as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we add the same couple of tests for "featureTest" (not rollout) as well?

jaeopt
jaeopt approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 1f14ca5 into master Feb 12, 2021
@jaeopt jaeopt deleted the mnoman/DispatchedEventTests branch February 12, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @jaeopt @msohailhussain