Skip to content

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Add check for ProjectConfig in odp methods.
    This will ensure the datafile has been fetched first.

Test plan

all tests pass

Ticket

FSSDK-9055

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review April 14, 2023 14:04
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner April 14, 2023 14:04
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit bc80d72 into master Apr 18, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/block_odp_calls_on_datafile branch April 18, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants