Skip to content

[FSSDK-9055] fix: send config update notification before unblocking #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

[FSSDK-9055] fix: send config update notification before unblocking #349

merged 1 commit into from
Apr 28, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely commented Apr 26, 2023 •
edited
Loading

Summary

  • Send config update notification before unblocking so odp config is updated.

Test plan

all tests pass

Ticket

FSSDK-9055

@andrewleap-optimizely andrewleap-optimizely changed the title fix: send config update notification before unblocking [FSSDK-9055] fix: send config update notification before unblocking Apr 26, 2023
@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review April 26, 2023 23:23
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner April 26, 2023 23:23
jaeopt
jaeopt approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mikechu-optimizely
mikechu-optimizely approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit bcafbc0 into master Apr 28, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/fix_update_odp_config branch April 28, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @jaeopt @mikechu-optimizely