Skip to content

[FSSDK-9108] Fix upload to AWS #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 1, 2023
Merged

[FSSDK-9108] Fix upload to AWS #351

merged 7 commits into from
May 1, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Fix GitHub Actions yaml so S3 upload with correct file names succeed

Test plan

  • All existing tests should pass
  • I should see the correct unsigned DLLs in S3

Issues

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review May 1, 2023 13:32
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner May 1, 2023 13:32
andrewleap-optimizely
andrewleap-optimizely approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit 7bb4f03 into master May 1, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/prep-4-0-0-beta branch May 1, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @andrewleap-optimizely