Skip to content

[FSSDK-9044] chore: Updated jquery lib version in demo app #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

[FSSDK-9044] chore: Updated jquery lib version in demo app #352

merged 1 commit into from
Jun 14, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jun 9, 2023

Summary

  • Updated jquery version to latest 3.7.0
  • Updated Jquery.Validation version to 1.19.5

Test plan

All tests should pass.

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner June 9, 2023 11:35
@mnoman09 mnoman09 removed their assignment Jun 12, 2023
Mat001
Mat001 approved these changes Jun 13, 2023
View reviewed changes
Copy link

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

What are the gitactions warnings in some files?

@mnoman09 mnoman09 merged commit 1ccd2e3 into master Jun 14, 2023
@mnoman09 mnoman09 deleted the mnoman/JqueryLibUpdate branch June 14, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@mikechu-optimizely mikechu-optimizely Awaiting requested review from mikechu-optimizely

Assignees
No one assigned
Labels
🤖 8 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnoman09 @Mat001 @optimizely-codereview-bot @NomanShoaib