Skip to content

[FSSDK-8701]: Added missing methods in Optimizely interface #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

[FSSDK-8701]: Added missing methods in Optimizely interface #353

merged 1 commit into from
Jun 16, 2023

Conversation

mnoman09
Copy link
Contributor

Summary

  • Added missing methods in IOptimizely interface: GetFeatureVariableJSON(), GetOptimizelyConfig() and GetAllFeatureVariables()

Test plan

All tests should pass.

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner June 16, 2023 00:59
jaeopt
jaeopt approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnoman09 mnoman09 merged commit ae53b62 into master Jun 16, 2023
@mnoman09 mnoman09 deleted the mnoman/IOptimizelyMethods branch June 16, 2023 16:22
This was referenced Jun 20, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @jaeopt @NomanShoaib