GetVariation should return variation object. #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of string variation key.
|
Can one of the admins verify this patch? |
|
build |
mikeproeng37
approved these changes
Dec 13, 2017
There was a problem hiding this comment.
lgtm
I ran e2e tests and they pass with the exception of one known failing test: https://jenkins.dz.optimizely.com/job/fullstack-e2e-csharp/434/console
kellyroach-optimizely
pushed a commit
that referenced
this pull request
Dec 14, 2017
kellyroach-optimizely
added a commit
that referenced
this pull request
Dec 15, 2017
This reverts commit 3740441.
kellyroach-optimizely
added a commit
that referenced
this pull request
Dec 20, 2017
* *.nuspec more like it was in 1.2.0 . Some improvements survive. * pack.ps1 only packages Optimizely's *.dll's * Revert "isfeatureenabled should return boolean value. (#39)" This reverts commit 97ac579. * 'Feature Flags & Rollout' not included in 1.3.0 * 'Feature Flags & Rollout' DecisionService.cs code not included in 1.3.0 * notification center property in optimizely class changed into public access modifier. (#40) * GetVariation should return variation object. (#41) * Revert "GetVariation should return variation object. (#41)" This reverts commit 3740441. * Update CHANGELOG.md * Update CHANGELOG.md '1.3.0' release date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# SDK should return variation object instead of variation key,