Feature toggleability #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
build |
mikeproeng37
suggested changes
Feb 20, 2018
| @@ -317,6 +317,10 @@ public void TestInit() | |||
| }; | |||
|
|
|||
| Assert.IsTrue(TestData.CompareObjects(expectedRolloutIdMap, Config.RolloutIdMap)); | |||
|
|
|||
| // Verify that featureEnabled property of variation is false if not defined. | |||
| var variation = new Variation { Id = "test_experiment", Key = "control" }; | |||
There was a problem hiding this comment.
Please separate out into its own test case
OptimizelySDK.Tests/TestData.json
Outdated
| @@ -16,11 +16,13 @@ | |||
| "audienceIds": ["7718080042"], | |||
| "variations": [{ | |||
| "id": "7722370027", | |||
| "key": "control" | |||
| "key": "control", | |||
There was a problem hiding this comment.
Are these feature experiments? We should only be adding it to variations that belong to experiments that have a feature attached to them.
OptimizelySDK/Optimizely.cs
Outdated
| @@ -355,21 +355,16 @@ public virtual bool IsFeatureEnabled(string featureKey, string userId, UserAttri | |||
| return false; | |||
|
|
|||
| var decision = DecisionService.GetVariationForFeature(featureFlag, userId, userAttributes); | |||
| if (decision == null) | |||
| if (decision == null || !decision.Variation.FeatureEnabled) | |||
There was a problem hiding this comment.
Can you null-check the Variation as well
separate test case as per suggestion.
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.