Skip to content

Kroach/oasis 3134 release master #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2018

Conversation

kellyroach-optimizely
Copy link
Contributor

This pull request synchs 2.0.x branch changes onto the master branch.
It gets CHANGELOG.md and 2.0.1 version bump changes into master.

* GetEnabledFeatures now returns sorted features list. (#69)

* GetEnabledFeatures now returns sorted features list ignoring case

* Removes sorting from GetEnabledFeatures method. (#73)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#72)

* OASIS-2504 [C#] Release 2.0.0-beta1 (#71)

* Revert "Eventdispatcherissue (#35) (#54)"

This reverts commit 5df7cfb.

* Bump version to 2.0 beta.

* Update OptimizelySDK.nuspec

* AssemblyVersion = 2.0.0.0

* Improved 1.3.1 DemoApp

* Updated OptimizelySDK.Package and OptimizelySDK.nuspec

* keypair.snk for *.sln, *.csproj

* CHANGELOG.md corrections

* SDK_VERSION synch with NuGet package version.

* Make 'UserAttributes userAttributes = null' optional in 5 API's

* Update verifysn.ps1 and DemoApp.csproj to 2.0.0-beta1

* Correct 2.0.0-beta1 release date in CHANGELOG.md

* 2.0.0-beta1 --> 2.0.0 (#74) (#75)

* Input validation in Activate, Track and GetVariation methods. (#76)

* Input validation in Activate, Track and GetVariation methods.

* Replaced InputType enum with string constants.

* Updates unit tests.

* Fix impression sent from feature experiment variation toggled off.

* Revert "Fix impression sent from feature experiment variation toggled off."

This reverts commit c943747.

* Fix impression sent from feature experiment variation toggled off. (#84)

* Update OptimizelySDK.DemoApp.csproj OptimizelySDK Reference

* Update AssemblyVersion, AssemblyFileVersion, AssemblyInformationalVersion

* Update the OptimizelySDK.Package/OptimizelySDK.nuspec

* Upgrade DemoApp to OptimizelySDK 2.0.1
@kellyroach-optimizely
Copy link
Contributor Author

TEST:

  • unit tests 184/184 PASSED
  • DemoApp
    ProjectId == 10024900058 (AKA "add_to_cart" project)
    ExperimentKey == "my_experiment"
    EventKey == "add_to_cart" // "AddToCart" prior to 1.3.x
    Using 2.0.1 *.nupkg pulled down from NUGET.ORG .
    We got the predicted 5 visitors results on OPTIMIZELY.COM PASSED
  • E2E tests
    =================== 177 passed, 12 skipped in 26.10 seconds ====================
    PASSED

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kellyroach-optimizely kellyroach-optimizely merged commit da13545 into master Jun 21, 2018
@aliabbasrizvi aliabbasrizvi deleted the kroach/OASIS-3134-release-master branch June 27, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants