Skip to content

make status optional in the creation of live variables #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2017
Merged

make status optional in the creation of live variables #126

merged 1 commit into from
Jul 11, 2017

Conversation

wangjoshuah
Copy link
Contributor

@optimizely/fullstack-devs

mikeproeng37
mikeproeng37 approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wangjoshuah wangjoshuah merged commit 32c4d15 into master Jul 11, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/live_variable_status_optional branch July 11, 2017 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@vraja2 vraja2 Awaiting requested review from vraja2

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangjoshuah @mikeproeng37