Add support for numeric metrics #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganlinn
reviewed
Jul 17, 2017
| Double eventValue = null; | ||
| if (eventTags.containsKey(ReservedEventKey.VALUE.toString())) { | ||
| Object rawValue = eventTags.get(ReservedEventKey.VALUE.toString()); | ||
| if (rawValue instanceof Double) { |
There was a problem hiding this comment.
It's reasonable to let this be anything that implements Number IMO. I think this will lead to confusing behavior
There was a problem hiding this comment.
makes sense, the opposite case is the one that we should be wary of (truncating floating-point values)
wangjoshuah
suggested changes
Jul 17, 2017
| eventMetrics.add(new EventMetric(EventMetric.REVENUE_METRIC_TYPE, revenueValue)); | ||
| } | ||
|
|
||
| Double numericMetricValue = EventTagUtils.getNumericValue(eventTags); |
There was a problem hiding this comment.
@vraja2 can there only be one numeric metric value?
There was a problem hiding this comment.
yes, it will correspond to the event being tracked.
| public boolean equals(Object other) { | ||
| if (!(other instanceof EventMetric)) | ||
| return false; | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
please don't name variables single characters
There was a problem hiding this comment.
intellij auto-generated, will change to obj
aliabbasrizvi
suggested changes
Jul 18, 2017
wangjoshuah
approved these changes
Jul 31, 2017
|
@vraja2 will add docs to explain why they should send us floats or doubles instead of int/long |
aliabbasrizvi
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@optimizely/fullstack-devs