Skip to content

feature variable accessor apis #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2017
Merged

feature variable accessor apis #133

merged 4 commits into from
Aug 16, 2017

Conversation

wangjoshuah
Copy link
Contributor

  • link feature variable accessors to feature variable by value and type
  • add unit tests for getFeatureVariable calling through to internals
  • add unit tests to catch parsing error

@wangjoshuah
Copy link
Contributor Author

@optimizely/fullstack-devs

@wangjoshuah wangjoshuah force-pushed the josh.wang/link_feature_variable_accessor_apis branch from 9186b82 to 2e61284 Compare August 16, 2017 17:13
mikeproeng37
mikeproeng37 approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wangjoshuah wangjoshuah merged commit 1f0e341 into master Aug 16, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/link_feature_variable_accessor_apis branch August 16, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@vraja2 vraja2 Awaiting requested review from vraja2

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangjoshuah @mikeproeng37