Skip to content

use trusty distribution #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 28, 2017
Merged

use trusty distribution #145

merged 18 commits into from
Sep 28, 2017

Conversation

wangjoshuah
Copy link
Contributor

@wangjoshuah wangjoshuah commented Sep 25, 2017

Upgrade travis-ci travis.yml to use trusty distribution since that is their new standard.
The gradle version of their linux distribution is gradle 4.0.1 so I upgraded our gradle wrapper to that.
That required we upgrade our nebula dependency to 3.2.0.
Drop support for JDK 7 until travis-ci can fix that.

provided group: 'org.json', name: 'json', version: jsonVersion, optional
provided group: 'com.googlecode.json-simple', name: 'json-simple', version: jsonSimpleVersion, optional
provided group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: jacksonVersion, optional
compile group: 'com.google.code.gson', name: 'gson', version: gsonVersion, optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing these to compile will result in all of these JSON libraries being packaged with the SDK which will increase bloat. provided was used to give that dependency flexibility to the consumer.

.travis.yml Outdated
@@ -1,13 +1,14 @@
language: java
dist: precise
dist: trusty
sudo: required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason we need root privileges?

.travis.yml Outdated
jdk:
- openjdk7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think openjdk7 should still be supported.

@wangjoshuah
Copy link
Contributor Author

@vraja2 travis-ci.org is ending support for dist: precise. We are migrating to dist: trusty do ensure support. https://blog.travis-ci.com/2017-08-31-trusty-as-default-status

The trusty distribution uses gradle 4.0.1 which is incompatible with our current version of nebula. We will use nebula 3.2.0 to allow us to continue testing all parsers. https://github.com/nebula-plugins/gradle-extra-configurations-plugin

@wangjoshuah wangjoshuah merged commit 77ed839 into master Sep 28, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/use_trusty branch September 28, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants