revise rollout bucketing to check audience in last rollout rule #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 486
💛 - Coveralls |
| // get last rule which is the fall back rule | ||
| Experiment finalRule = rollout.getExperiments().get(rolloutRulesLength - 1); | ||
| if (ExperimentUtils.isUserInExperiment(projectConfig, finalRule, filteredAttributes)) { | ||
| variation = bucketer.bucket(finalRule, bucketingId); // ignore audience |
There was a problem hiding this comment.
We no longer ignore audience so this comment is incorrect
There was a problem hiding this comment.
This comment is still incorrect
| @@ -217,34 +217,26 @@ public DecisionService(@Nonnull Bucketer bucketer, | |||
| Variation variation; | |||
| for (int i = 0; i < rolloutRulesLength - 1; i++) { | |||
| Experiment rolloutRule = rollout.getExperiments().get(i); | |||
| Audience audience = projectConfig.getAudienceIdMapping().get(rolloutRule.getAudienceIds().get(0)); | |||
There was a problem hiding this comment.
I think these log messages are still useful
| variation = bucketer.bucket(rolloutRule, bucketingId); | ||
| if (variation == null) { | ||
| logger.debug("User \"{}\" was excluded due to traffic allocation.", userId); |
There was a problem hiding this comment.
This one we can definitely get rid of
| break; | ||
| } | ||
| return new FeatureDecision(rolloutRule, variation, | ||
| FeatureDecision.DecisionSource.ROLLOUT); | ||
| } else { | ||
| logger.debug("User \"{}\" did not meet the conditions to be in rollout rule for audience \"{}\".", |
There was a problem hiding this comment.
This is still helpful for debugging
mikeproeng37
suggested changes
Mar 20, 2018
| // get last rule which is the fall back rule | ||
| Experiment finalRule = rollout.getExperiments().get(rolloutRulesLength - 1); | ||
| if (ExperimentUtils.isUserInExperiment(projectConfig, finalRule, filteredAttributes)) { | ||
| variation = bucketer.bucket(finalRule, bucketingId); // ignore audience |
There was a problem hiding this comment.
This comment is still incorrect
mikeproeng37
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.