Refactor experiment and events getters #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wangjoshuah
commented
Apr 12, 2018
- Remove throws declarations on methods since we never actually throw.
- Change docs to explain that we send it to the error handler instead
…Change docs to explain that we send it to the error handler instead
Pull Request Test Coverage Report for Build 504
💛 - Coveralls |
mikeproeng37
approved these changes
Apr 12, 2018
| getExperimentKeyMapping() | ||
| .get(experimentKey); | ||
|
|
||
| // if the given experiment key isn't present in the config, log and potentially throw an exception |
There was a problem hiding this comment.
Revise comment on throwing error
| getEventNameMapping() | ||
| .get(eventName); | ||
|
|
||
| // if the given event name isn't present in the config, log and potentially throw an exception |
There was a problem hiding this comment.
No exceptions anymore!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.