Source Clear Improvements #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliabbasrizvi
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Background
Results from Source Clear were 1 vulnerability and several suggested library updates. The following changes were made largely with the suggestions Source Clear made. All the information below is also in our Source Clear account.
Vulnerability
Apache httpclient 4.5.2had a security vulnerability, in which Source Clear suggests a package update. Looking through the Source Clear Vulnerability Database,4.5.6does not have any vulnerabilities and is the most recent package. (There were also 5.0 beta versions that were breaking our code.)Libraries
There were several libraries that were outdated, in which some libraries were dependent on other libraries. The only library upgrade suggestion that I did not follow was
SLF4J 1.8.0-beta2, and I upgraded it to1.7.25instead.1.8.0-beta2broke the code, so I elected to upgrade it to the most current 1.7.x version. We were also usingfindBugsVersionon two different librariesannotationsandjsr305. One required an update, so I chose to specify the versions for the two libraries.Testing
Build with
./gradlew buildhad no errors. Ran and passed./gradlew test, and./gradlew check.