Skip to content

Fix: Added toString() on decisionSource so that rollout keys of enums get picked #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2019
Merged

Fix: Added toString() on decisionSource so that rollout keys of enums get picked #285

merged 1 commit into from
Apr 24, 2019

Conversation

mnoman09
Copy link
Contributor

Summary

  • sending decision source rollout and feature-test keys by adding toString().
  • This change is due to currently source value ROLLOUT and FEATURE_TEST was getting sent in notification.

Test plan

Updated unit Tests

@mnoman09 mnoman09 requested a review from aliabbasrizvi April 24, 2019 13:57
@mnoman09 mnoman09 self-assigned this Apr 24, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 984

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.613%
Totals Coverage Status
Change from base Build 981: 0.03%
Covered Lines: 2847
Relevant Lines: 3177
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 984

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.613%
Totals Coverage Status
Change from base Build 981: 0.03%
Covered Lines: 2847
Relevant Lines: 3177
💛 - Coveralls

@aliabbasrizvi aliabbasrizvi merged commit 82691ed into master Apr 24, 2019
@aliabbasrizvi aliabbasrizvi deleted the mnoman/ListenerRolloutSmallBugFix branch April 24, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @coveralls @aliabbasrizvi