Making Optimizely Autocloseable #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliabbasrizvi
commented
May 6, 2019
Pull Request Test Coverage Report for Build 1024
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1042
💛 - Coveralls |
mikecdavis
reviewed
May 8, 2019
32ced5e to
12d3483
Compare
mikecdavis
suggested changes
May 8, 2019
| verify((Closeable) mockCloseableProjectConfigManager).close(); | ||
| } | ||
|
|
||
| @Test(expected = IOException.class) |
There was a problem hiding this comment.
We don't want to throw an exception. I think we should be catching all exceptions.
mikecdavis
reviewed
May 9, 2019
| public void close() { | ||
| if (eventHandler instanceof Closeable) { | ||
| try { | ||
| ((Closeable) eventHandler).close(); |
There was a problem hiding this comment.
Maybe best to create a tryClose(Object obj) method.
private void tryClose(Object obj) {
if (!(obj instanceof Closeable)) {
return;
}
try {
((Closeable) obj).close();
} catch (Exception e) {
logger.warn("Unexpected exception on trying to close {}.", obj);
}
}
| * | ||
| * <b>NOTE:</b> There is a chance that this could be long running if the implementations of close are long running. | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
Nit, spacing is not consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making Optimizely
Autocloseableand calling close onEventHandlerandProjectConfigManagerif they areCloseablethemselves.