Skip to content

Add package level README.md for core-httpclient-impl #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2019

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Add package level README.md for core-httpclient-impl
  • Fix bug where invalid input was not defaulted as the log indicates.

@coveralls
Copy link

coveralls commented May 20, 2019

Pull Request Test Coverage Report for Build 1066

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.741%

Totals Coverage Status
Change from base Build 1060: 0.2%
Covered Lines: 3298
Relevant Lines: 3675

💛 - Coveralls

Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## HttpProjectConfigManager

The `HttpProjectConfigManager` is an implementation of the abstract `PollingProjectConfigManager`. The `poll`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. May be useful to link to the class and the abstract.

@mikecdavis mikecdavis merged commit ba01220 into master May 22, 2019
@mikecdavis mikecdavis deleted the mikecdavis/OASIS-4503-add-readme branch May 22, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants