Skip to content

OASIS-4503: Copy edit README #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

OASIS-4503: Copy edit README #305

wants to merge 2 commits into from

Conversation

hillaryfraley-optimizely
Copy link

@hillaryfraley-optimizely
Copy link
Author

Unresolved questions:

  1. Should we list all available options for each configuration parameter? For example, are other units besides minutes available for http.project.config.manager.polling.unit? Are other units besides seconds available for http.project.config.manager.blocking.unit?

  2. Do we need to link to instructions for finding SDK key?

mikecdavis
mikecdavis approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edit!

@mikecdavis mikecdavis mentioned this pull request May 24, 2019
Merged
@mikecdavis
Copy link
Contributor

Edits ported to #306

@mikecdavis mikecdavis closed this Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikecdavis mikecdavis mikecdavis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hillaryfraley-optimizely @mikecdavis