Skip to content

Incorporate copy edits. #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2019
Merged

Incorporate copy edits. #306

merged 2 commits into from
May 24, 2019

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Incorporate copy edits suggested [here|https://github.com/OASIS-4503: Copy edit README #305]
  • Differences with the copy edits are line spacing in the code samples and also including line breaks to make it easier to read without formatting applied.
  • Copy edits also implied the existence of optimizely.properties, but users must supply one.

@mikecdavis mikecdavis requested a review from aliabbasrizvi May 24, 2019 22:55
@coveralls
Copy link

coveralls commented May 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1077

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.741%
Totals Coverage Status
Change from base Build 1072: 0.0%
Covered Lines: 3298
Relevant Lines: 3675
💛 - Coveralls

@aliabbasrizvi aliabbasrizvi merged commit 82b08c0 into master May 24, 2019
@aliabbasrizvi aliabbasrizvi deleted the mikecdavis/copy-edits branch May 24, 2019 23:20
mikecdavis pushed a commit that referenced this pull request Jun 26, 2019
Incorporate copy edits. (#306)
636db67
@mikecdavis mikecdavis mentioned this pull request Jul 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecdavis @coveralls @aliabbasrizvi