Skip to content

Restoring constructors for AsyncEventHandler #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

Restoring constructors for AsyncEventHandler #307

merged 1 commit into from
May 30, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

Restoring and marking them as deprecated

@aliabbasrizvi aliabbasrizvi requested a review from mikecdavis May 29, 2019 22:03
@coveralls
Copy link

coveralls commented May 29, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1079

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.644%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core-httpclient-impl/src/main/java/com/optimizely/ab/event/AsyncEventHandler.java 0 4 0.0%
Totals Coverage Status
Change from base Build 1078: -0.1%
Covered Lines: 3298
Relevant Lines: 3679
💛 - Coveralls

@aliabbasrizvi aliabbasrizvi merged commit eb630ed into master May 30, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/restore_async_handler branch May 30, 2019 20:23
mikecdavis pushed a commit that referenced this pull request Jun 26, 2019
@aliabbasrizvi
Restoring constructors for AsyncEventHandler (#307)
04fd855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikecdavis mikecdavis mikecdavis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliabbasrizvi @coveralls @mikecdavis