Skip to content

Fix blocking behavior when sending update notification. #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2019
Merged

Fix blocking behavior when sending update notification. #313

merged 5 commits into from
Jun 26, 2019

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Trigger the UpdateConfigNotification after resolving the countdownlatch.

Since notifications are triggered synchronously in the calling thread, there was potential to unnecessarily block until the timeout if the notification listener was also calling .getConfig()

Test plan

Unit test was added to confirm the issue, then validate the solution.

@coveralls
Copy link

coveralls commented Jun 21, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1107

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.719%
Totals Coverage Status
Change from base Build 1101: 0.0%
Covered Lines: 3412
Relevant Lines: 3803
💛 - Coveralls

msohailhussain
msohailhussain approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mikeproeng37
mikeproeng37 approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aliabbasrizvi
aliabbasrizvi approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecdavis mikecdavis merged commit 43d7600 into master Jun 26, 2019
@mikecdavis mikecdavis deleted the mikecdavis/OASIS-4934-fix-deadlock branch June 26, 2019 16:41
mikecdavis pushed a commit that referenced this pull request Jun 26, 2019
Fix blocking behavior when sending update notification. (#313)
4c0e009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikecdavis @coveralls @mikeproeng37 @aliabbasrizvi @msohailhussain