Skip to content

Fix up quickstart app. #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Remove package specific gradle.
  • Update quickstart README.md
  • Add gradle task to execute example.

This also fixes the version collision when publishing the SDK.

@mikecdavis mikecdavis requested a review from aliabbasrizvi July 24, 2019 17:08
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. Looks good.


## Getting Started
Simply create a experiment on app.optimizely.com named "background_experiment" with variation_a and variation_b and one conversion event "simple_conversion." Use that SDK key in the Example.java and you are set to test.
Create an experiment on app.optimizely.com named "background_experiment" with variation_a and variation_b and one conversion event "simple_conversion.".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. with variations "variation_a" and "variation_b"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is sample_conversion and not simple_conversion

@coveralls
Copy link

coveralls commented Jul 24, 2019

Pull Request Test Coverage Report for Build 1162

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.768%

Totals Coverage Status
Change from base Build 1160: 0.0%
Covered Lines: 3597
Relevant Lines: 4007

💛 - Coveralls

@mikecdavis mikecdavis merged commit b68d9f3 into master Jul 24, 2019
@mikecdavis mikecdavis deleted the mikecdavis/fix-up-example-quickstart branch July 24, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants