Skip to content

Update changelog for 3.2.1. #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 19, 2019
Merged

Update changelog for 3.2.1. #332

merged 6 commits into from
Aug 19, 2019

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Update changelog to release 3.2.1

@mikecdavis mikecdavis requested a review from a team as a code owner August 16, 2019 21:10
aliabbasrizvi
aliabbasrizvi approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Fix date I guess.

CHANGELOG.md Outdated
@@ -1,5 +1,12 @@
# Optimizely Java X SDK Changelog

## 3.2.1
August 26th, 2019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This date is 10 days into the future. I am assuming you meant 16th.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like Ali said, fix date.

@mikecdavis mikecdavis merged commit 444eac6 into master Aug 19, 2019
@mikecdavis mikecdavis deleted the mikecdavis/prepare-3.2.1 branch August 19, 2019 21:13
mikecdavis pushed a commit that referenced this pull request Aug 19, 2019
Update changelog for 3.2.1. (#332)
718cc54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mikecdavis mikecdavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecdavis @aliabbasrizvi @thomaszurkan-optimizely