Skip to content

(chore): release off of master #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2019
Merged

(chore): release off of master #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Optimizely Java X SDK Changelog

## 3.3.3
November 14th, 2019

### New Features:
- Require EventHandler in BatchEventProcessor builder. ([#333](https://github.com/optimizely/java-sdk/pull/333))
- Defend against invalid BatchEventProcessor configuration overrides. i([#331](https://github.com/optimizely/java-sdk/pull/331))

## 3.3.2
October 23rd, 2019

Expand Down
11 changes: 11 additions & 0 deletions core-api/src/main/java/com/optimizely/ab/Optimizely.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public class Optimizely implements AutoCloseable {
@VisibleForTesting
final DecisionService decisionService;
@VisibleForTesting
@Deprecated
final EventHandler eventHandler;
@VisibleForTesting
final EventProcessor eventProcessor;
Expand Down Expand Up @@ -1032,11 +1033,21 @@ public Builder withErrorHandler(ErrorHandler errorHandler) {
return this;
}

/**
* The withEventHandler has has been moved to the EventProcessor which takes a EventHandler in it's builder
* method.
* {@link com.optimizely.ab.event.BatchEventProcessor.Builder#withEventHandler(com.optimizely.ab.event.EventHandler)} label}
* Please use that builder method instead.
*/
@Deprecated
public Builder withEventHandler(EventHandler eventHandler) {
this.eventHandler = eventHandler;
return this;
}

/**
* You can instantiate a BatchEventProcessor or a ForwardingEventProcessor or supply your own.
*/
public Builder withEventProcessor(EventProcessor eventProcessor) {
this.eventProcessor = eventProcessor;
return this;
Expand Down