Skip to content

prepare for 3.4.0 release #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

prepare for 3.4.0 release #355

merged 1 commit into from
Jan 27, 2020

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jan 24, 2020

Summary

  • Prepare for 3.4.0 release

@jaeopt jaeopt requested a review from mikecdavis January 24, 2020 23:54
@jaeopt jaeopt requested a review from a team as a code owner January 24, 2020 23:54
@coveralls
Copy link

coveralls commented Jan 25, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1336

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.278%
Totals Coverage Status
Change from base Build 1333: 0.0%
Covered Lines: 3747
Relevant Lines: 4197
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mikecdavis
mikecdavis approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the date is the 27th. Not sure if that was intentional.

@jaeopt jaeopt merged commit b6d3a0b into master Jan 27, 2020
@jaeopt jaeopt deleted the prepare-3.4.0 branch January 27, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@mikecdavis mikecdavis mikecdavis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaeopt @coveralls @mikeproeng37 @mikecdavis