Skip to content

fix: slight fix to get complete string #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: slight fix to get complete string #395

wants to merge 1 commit into from

Conversation

thomaszurkan-optimizely
Copy link
Contributor

Summary

  • Pass back complete string after split from build or pre-release
    The "why", or other context.

Test plan

Issues

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner September 2, 2020 19:03
msohailhussain
msohailhussain approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Please update summary, remove irrelevant stuff from summary.

@coveralls
Copy link

coveralls commented Sep 2, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1507

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.582%
Totals Coverage Status
Change from base Build 1506: 0.0%
Covered Lines: 4119
Relevant Lines: 4598
💛 - Coveralls

@thomaszurkan-optimizely thomaszurkan-optimizely deleted the patchSemver branch September 2, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@thomaszurkan-optimizely thomaszurkan-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @coveralls @msohailhussain