Skip to content

Fix: Resolved log4j vulnerability issue #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 15, 2020
Merged

Fix: Resolved log4j vulnerability issue #398

merged 7 commits into from
Sep 15, 2020

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Sep 15, 2020 •
edited
Loading

Summary

  • vulnerability of log4j is fixed
  • replaced slf4j-log4j12 library with log4j-slf4j-impl gradle of quick start demo project. It was causing log4j 1.2.17 vulnerability issue.

@mnoman09 mnoman09 requested a review from a team as a code owner September 15, 2020 14:49
@coveralls
Copy link

coveralls commented Sep 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1538

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.582%
Totals Coverage Status
Change from base Build 1531: 0.0%
Covered Lines: 4119
Relevant Lines: 4598
💛 - Coveralls

@mnoman09
testing
7ad9b9f
@mnoman09
testing
0a12554
@mnoman09
testing
1d327a0
@mnoman09
Replaced compile (group: 'org.slf4j', name: 'slf4j-log4j12', version:…
02030b0 
… '1.7.30') with

    compile group: 'org.apache.logging.log4j', name: 'log4j-slf4j-impl', version: '2.13.3'
as due to transitive property of log4j 1.2.17 its causing vulnerability issue
@msohailhussain msohailhussain marked this pull request as draft September 15, 2020 16:31
@mnoman09 mnoman09 changed the title testing Fix: Resolved log4j vulnerability issue Sep 15, 2020
@msohailhussain msohailhussain marked this pull request as ready for review September 15, 2020 17:22
jaeopt
jaeopt approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 2ffd6d9 into master Sep 15, 2020
@jaeopt jaeopt deleted the mnoman/testingSourceClear branch September 15, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @coveralls @jaeopt