Skip to content

fix(audience): log debug instead of warning for missing attribute value #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 16, 2022
Merged

fix(audience): log debug instead of warning for missing attribute value #463

merged 5 commits into from
Feb 16, 2022

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Feb 11, 2022 •
edited
Loading

Summary

  • When an attribute value is missing, semantic-version matcher returns the "unexpected-value" error message as the WARNING level.
  • The same wrong error message is also given for exact matcher when the value is number type.
  • This is fixed to the "missing-attribute" message as the DEBUG level, to be consistent with other condition matchers.

Test plan

  • Unit tests for all matchers with missing attribute value.

Issues

@jaeopt jaeopt requested a review from a team as a code owner February 11, 2022 01:15
@coveralls
Copy link

coveralls commented Feb 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1951

  • 7 of 7 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.752%
Totals Coverage Status
Change from base Build 1950: 0.01%
Covered Lines: 4877
Relevant Lines: 5374
💛 - Coveralls

@jaeopt jaeopt removed their assignment Feb 11, 2022
@jaeopt jaeopt mentioned this pull request Feb 11, 2022
Closed
@jaeopt jaeopt changed the title fix(semantic-version): log debug instead of warning for missing attribute value fix(audience): log debug instead of warning for missing attribute value Feb 14, 2022
msohailhussain
msohailhussain reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update copyright

msohailhussain
msohailhussain approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please update copyright.

@jaeopt jaeopt merged commit d8df159 into master Feb 16, 2022
@jaeopt jaeopt deleted the jae/sem-warn branch February 16, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
🤖 20 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaeopt @coveralls @msohailhussain @optimizely-codereview-bot