Skip to content

refact(odp): Removes support for odp batchSize. #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

refact(odp): Removes support for odp batchSize. #500

merged 1 commit into from
Jan 17, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jan 10, 2023 •
edited by jaeopt
Loading

Summary

  • Removes support for changing odp batchSize.
  • If flush interval is set to 0, batchSize will be set to 1 to dispatch events immediately.

Test plan

  • Fixed unit tests
  • All previous tests should pass.

Jira

  • FSSDK-8386

@mnoman09 mnoman09 requested a review from a team as a code owner January 10, 2023 14:26
@mnoman09 mnoman09 changed the title Removed setting up batchSize and it will set it to 1 when you set flushInterval to 0 refact(odp): Removes support for odp batchSize. Jan 10, 2023
@mnoman09 mnoman09 removed their assignment Jan 10, 2023
jaeopt
jaeopt approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit ac27ae7 into master Jan 17, 2023
@jaeopt jaeopt deleted the mnoman/remove-odp-batchsize branch January 17, 2023 17:15
@jaeopt
Copy link
Contributor

jaeopt commented Jan 17, 2023

Forced merged since conflict with testapp fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnoman09 @jaeopt @optimizely-codereview-bot @NomanShoaib