Skip to content

[FSSDK-11152] update: add remove method in LRU Cache for CMAB service #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 14, 2025
Merged

[FSSDK-11152] update: add remove method in LRU Cache for CMAB service #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2640eaa
Cmab datafile parsed
FarhanAnjum-opti Aug 11, 2025
ad048df
Merge branch 'master' into farhan-anjum/FSSDK-11134-cmab-datafile-par…
FarhanAnjum-opti Aug 11, 2025
2d21ee2
Add CMAB configuration and parsing tests with cmab datafile
FarhanAnjum-opti Aug 12, 2025
0d3a88d
Add copyright notice to CmabTest and CmabParsingTest files
FarhanAnjum-opti Aug 12, 2025
50334f1
Refactor cmab parsing logic to simplify null check in JsonConfigParser
FarhanAnjum-opti Aug 12, 2025
87c553c
Merge branch 'master' into farhan-anjum/FSSDK-11134-cmab-datafile-par…
FarhanAnjum-opti Aug 12, 2025
8258bb0
update: implement remove method in DefaultLRUCache for cache entry re…
FarhanAnjum-opti Aug 12, 2025
4fa8cbe
add: implement remove method tests in DefaultLRUCacheTest for various…
FarhanAnjum-opti Aug 13, 2025
85b26d4
Merge branch 'master' into farhan-anjum/FSSDK-11152-update-lru-cache-…
FarhanAnjum-opti Aug 13, 2025
aa955eb
refactor: remove unused methods from Cache interface
FarhanAnjum-opti Aug 14, 2025
d3fc4bb
update: add reset method to Cache interface
FarhanAnjum-opti Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions core-api/src/main/java/com/optimizely/ab/internal/DefaultLRUCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,19 @@ public void reset() {
}
}

public void remove(String key) {
if (maxSize == 0) {
// Cache is disabled when maxSize = 0
return;
}
lock.lock();
try {
linkedHashMap.remove(key);
} finally {
lock.unlock();
}
}

private class CacheEntity {
public T value;
public Long timestamp;
Expand Down
86 changes: 86 additions & 0 deletions core-api/src/test/java/com/optimizely/ab/internal/DefaultLRUCacheTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,90 @@ public void whenCacheIsReset() {

assertEquals(0, cache.linkedHashMap.size());
}

@Test
public void testRemoveNonExistentKey() {
DefaultLRUCache<Integer> cache = new DefaultLRUCache<>(3, 1000);
cache.save("1", 100);
cache.save("2", 200);

cache.remove("3"); // Doesn't exist

assertEquals(Integer.valueOf(100), cache.lookup("1"));
assertEquals(Integer.valueOf(200), cache.lookup("2"));
}

@Test
public void testRemoveExistingKey() {
DefaultLRUCache<Integer> cache = new DefaultLRUCache<>(3, 1000);

cache.save("1", 100);
cache.save("2", 200);
cache.save("3", 300);

assertEquals(Integer.valueOf(100), cache.lookup("1"));
assertEquals(Integer.valueOf(200), cache.lookup("2"));
assertEquals(Integer.valueOf(300), cache.lookup("3"));

cache.remove("2");

assertEquals(Integer.valueOf(100), cache.lookup("1"));
assertNull(cache.lookup("2"));
assertEquals(Integer.valueOf(300), cache.lookup("3"));
}

@Test
public void testRemoveFromZeroSizedCache() {
DefaultLRUCache<Integer> cache = new DefaultLRUCache<>(0, 1000);
cache.save("1", 100);
cache.remove("1");

assertNull(cache.lookup("1"));
}

@Test
public void testRemoveAndAddBack() {
DefaultLRUCache<Integer> cache = new DefaultLRUCache<>(3, 1000);
cache.save("1", 100);
cache.save("2", 200);
cache.save("3", 300);

cache.remove("2");
cache.save("2", 201);

assertEquals(Integer.valueOf(100), cache.lookup("1"));
assertEquals(Integer.valueOf(201), cache.lookup("2"));
assertEquals(Integer.valueOf(300), cache.lookup("3"));
}

@Test
public void testThreadSafety() throws InterruptedException {
int maxSize = 100;
DefaultLRUCache<Integer> cache = new DefaultLRUCache<>(maxSize, 1000);

for (int i = 1; i <= maxSize; i++) {
cache.save(String.valueOf(i), i * 100);
}

Thread[] threads = new Thread[maxSize / 2];
for (int i = 1; i <= maxSize / 2; i++) {
final int key = i;
threads[i - 1] = new Thread(() -> cache.remove(String.valueOf(key)));
threads[i - 1].start();
}

for (Thread thread : threads) {
thread.join();
}

for (int i = 1; i <= maxSize; i++) {
if (i <= maxSize / 2) {
assertNull(cache.lookup(String.valueOf(i)));
} else {
assertEquals(Integer.valueOf(i * 100), cache.lookup(String.valueOf(i)));
}
}

assertEquals(maxSize / 2, cache.linkedHashMap.size());
}
}
Loading