Skip to content

Josh.wang/revise user profile #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Mar 21, 2017
Merged

Conversation

wangjoshuah
Copy link
Contributor

No description provided.

@wangjoshuah wangjoshuah requested a review from vraja2 March 5, 2017 05:42
BucketerTest.java
Add a public method to BucketerTest.java to calculate what bucket value
the bucketer hash should return to bucket a user into a specific
variation of an experiment.
Add `getVariationReturnsVaraitionStoredInUserProfileInsteadOfBucketing`
to OptimizelyTestV2 and OptimizelyTestV3.
Duplicate test into OptimizelyTestV2 and OptimizelyTestV3 as
`getVariationReturnsNullWhenInvalidVariationKeyIsFoundInForcedVariationsMapping`
BucketerTest into OptimizelyTestV2 and OptimizelyTestV3 as
`getVariationMakesForcedVariationOverrideExperimentBucketing`
BucketerTest to OptimizelyTestV2 and OptimizelyTestV3 as
`getVariationBucketsWhenNullReturnedFromUserProfileLookup`
BucketerTest to OptimizelyTestV2 and OptimizelyTestV3 as
`getVariationSavesActivationWithUserProfile`
move `bucketUserSaveActivationFailWithUserProfile()` from
BucketerTest to OptimizelyTestv2 and OptimizelyTestV3 as
getVariationLogsCorrectlyWhenuserProfileFailsToSave
…r profiles is cleaned by checking that getAllRecords was called on initialization of the Optimizely instance
@wangjoshuah wangjoshuah force-pushed the josh.wang/revise_user_profile branch from 223b14b to 04a4dfe Compare March 10, 2017 17:50
Copy link
Contributor

@vraja2 vraja2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to squash and merge

@wangjoshuah wangjoshuah merged commit c1b088a into devel Mar 21, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/revise_user_profile branch March 21, 2017 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants