-
Notifications
You must be signed in to change notification settings - Fork 32
Josh.wang/revise user profile #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BucketerTest.java Add a public method to BucketerTest.java to calculate what bucket value the bucketer hash should return to bucket a user into a specific variation of an experiment. Add `getVariationReturnsVaraitionStoredInUserProfileInsteadOfBucketing` to OptimizelyTestV2 and OptimizelyTestV3.
Duplicate test into OptimizelyTestV2 and OptimizelyTestV3 as `getVariationReturnsNullWhenInvalidVariationKeyIsFoundInForcedVariationsMapping`
BucketerTest into OptimizelyTestV2 and OptimizelyTestV3 as `getVariationMakesForcedVariationOverrideExperimentBucketing`
BucketerTest to OptimizelyTestV2 and OptimizelyTestV3 as `getVariationBucketsWhenNullReturnedFromUserProfileLookup`
BucketerTest to OptimizelyTestV2 and OptimizelyTestV3 as `getVariationSavesActivationWithUserProfile`
move `bucketUserSaveActivationFailWithUserProfile()` from BucketerTest to OptimizelyTestv2 and OptimizelyTestV3 as getVariationLogsCorrectlyWhenuserProfileFailsToSave
… that to generate the logs
…flow through getVariation anyways
…r profiles is cleaned by checking that getAllRecords was called on initialization of the Optimizely instance
223b14b
to
04a4dfe
Compare
Move bucketing logic to Bucketer.test getVariation stores user profile information precondition checks are still in get variation
…event builder calls
This reduces some code indents
remove some extraneous logging. change some comments remove wildcard imports move apply plugin 'idea' to allprojects in build.gradle
…e of this class is
vraja2
approved these changes
Mar 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make sure to squash and merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.