Skip to content

chore: add package-lock.json #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2018
Merged

chore: add package-lock.json #100

merged 3 commits into from
May 21, 2018

Conversation

tylerbrandt
Copy link
Contributor

No description provided.

@tylerbrandt tylerbrandt requested a review from mikeproeng37 May 21, 2018 21:25
@tylerbrandt
Copy link
Contributor Author

Was this intentional, or an oversight? If the former, we should add it to .gitignore.

mikeproeng37
mikeproeng37 approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight. There was no package-lock when we released two years ago and I think we were mostly using npm@3 up until recently. Seems like a good idea to check in.

@tylerbrandt tylerbrandt merged commit 149fada into master May 21, 2018
@tylerbrandt tylerbrandt deleted the tyler/package-lock branch May 21, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerbrandt @mikeproeng37