Skip to content

refactor(scripts): Use Karma CLI rather than grunt #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

spencerwilson-optimizely
Copy link
Contributor

@spencerwilson-optimizely spencerwilson-optimizely commented Jun 30, 2018

Summary

  • Drop grunt and related dependencies

Every Karma config option has a corresponding CLI option, which takes precedence over any option of the same name in the config file. We don't need to use grunt to run these tests. Additionally, I'm pushing the boundaries of the oldest Node.js versions we can run in CI, and grunt was a hangup for doing validation with 0.10.44.

Test plan

CI.

@coveralls
Copy link

coveralls commented Jun 30, 2018

Coverage Status

Coverage remained the same at 97.11% when pulling 22a353b on sw/drop-grunt into 05ec7d9 on master.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is much cleaner

@spencerwilson-optimizely spencerwilson-optimizely merged commit 0d314e7 into master Jul 2, 2018
@spencerwilson-optimizely spencerwilson-optimizely deleted the sw/drop-grunt branch July 2, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants