Skip to content

fix(package.json): Add license key #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2018
Merged

fix(package.json): Add license key #140

merged 1 commit into from
Jul 3, 2018

Conversation

spencerwilson-optimizely
Copy link
Contributor

Summary

This addresses the warning that is currently being logged during npm install @optimizely/optimizely-sdk:

npm WARN @optimizely/optimizely-sdk@2.1.1 No license field.

and fixes this on our NPM page:
screen shot 2018-07-03 at 12 17 13 pm

Test plan

rm -r node_modules ; npm install
...

No warnings!

@coveralls
Copy link

coveralls commented Jul 3, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.11% when pulling aedfa39 on sw/add-license into 958c0b6 on master.

@mikeproeng37
Copy link
Contributor

lgtm, thanks for adding this!

@spencerwilson-optimizely spencerwilson-optimizely merged commit 49e1e08 into master Jul 3, 2018
@spencerwilson-optimizely spencerwilson-optimizely deleted the sw/add-license branch July 3, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@tylerbrandt tylerbrandt Awaiting requested review from tylerbrandt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerwilson-optimizely @coveralls @mikeproeng37