Skip to content

chore(ci): Restore Node.js 10.x to Travis matrix #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

spencerwilson-optimizely
Copy link
Contributor

@spencerwilson-optimizely spencerwilson-optimizely commented Jul 3, 2018

Summary

  • Re-enable CI against latest Node.js 10.x release

It was disabled in #101, but from the example failure given in that PR, I suspect the bug lies in lerna. No matter now, since lerna has been bypassed since #129.

Test plan

CI

@coveralls
Copy link

coveralls commented Jul 3, 2018

Coverage Status

Coverage remained the same at 97.11% when pulling b9ce520 on sw/restore-node-10 into fbbf9f8 on master.

Copy link
Contributor

@tylerbrandt tylerbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@spencerwilson-optimizely spencerwilson-optimizely merged commit ff624de into master Jul 3, 2018
@spencerwilson-optimizely spencerwilson-optimizely deleted the sw/restore-node-10 branch July 3, 2018 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants