Skip to content

chore(deps): Migrate to sprintf-js #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2018
Merged

chore(deps): Migrate to sprintf-js #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0599cd3
chore(deps): Migrate from sprintf -> sprintf-js
spencerwilson-optimizely Aug 20, 2018
d93b369
Port imports to new format
spencerwilson-optimizely Aug 20, 2018
5d5adae
Merge branch 'master' into sw/upgrade-sprintf
spencerwilson-optimizely Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/bucketer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*/
var enums = require('../../utils/enums');
var murmurhash = require('murmurhash');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var ERROR_MESSAGES = enums.ERROR_MESSAGES;
var HASH_SEED = 1;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/bucketer/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var bucketer = require('./');
var enums = require('../../utils/enums');
var logger = require('../../plugins/logger');
var projectConfig = require('../project_config');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var testData = require('../../tests/test_data').getTestProjectConfig();

var chai = require('chai');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/decision_service/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ var enums = require('../../utils/enums');
var fns = require('../../utils/fns');
var projectConfig = require('../project_config');

var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var MODULE_NAME = 'DECISION_SERVICE';
var ERROR_MESSAGES = enums.ERROR_MESSAGES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/decision_service/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var DecisionService = require('./');
var enums = require('../../utils/enums');
var logger = require('../../plugins/logger');
var projectConfig = require('../project_config');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var testData = require('../../tests/test_data').getTestProjectConfig();
var testDataWithFeatures = require('../../tests/test_data').getTestProjectConfigWithFeatures();
var jsonSchemaValidator = require('../../utils/json_schema_validator');
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/notification_center/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

var enums = require('../../utils/enums');
var fns = require('../../utils/fns');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var LOG_LEVEL = enums.LOG_LEVEL;
var LOG_MESSAGES = enums.LOG_MESSAGES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/project_config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
var fns = require('../../utils/fns');
var enums = require('../../utils/enums');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var EXPERIMENT_LAUNCHED_STATUS = 'Launched';
var EXPERIMENT_RUNNING_STATUS = 'Running';
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/core/project_config/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var chai = require('chai');
var assert = chai.assert;
var logger = require('../../plugins/logger');
var sinon = require('sinon');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var ERROR_MESSAGES = enums.ERROR_MESSAGES;
var FEATURE_VARIABLE_TYPES = enums.FEATURE_VARIABLE_TYPES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/index.node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ var enums = require('./utils/enums');
var fns = require('./utils/fns');
var jsonSchemaValidator = require('./utils/json_schema_validator');
var logger = require('./plugins/logger');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var Optimizely = require('./optimizely');

Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/optimizely/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var eventTagsValidator = require('../utils/event_tags_validator');
var notificationCenter = require('../core/notification_center');
var projectConfig = require('../core/project_config');
var projectConfigSchema = require('./project_config_schema');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var userProfileServiceValidator = require('../utils/user_profile_service_validator');
var stringValidator = require('../utils/string_value_validator');

Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/optimizely/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var projectConfig = require('../core/project_config');
var chai = require('chai');
var assert = chai.assert;
var sinon = require('sinon');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var uuid = require('uuid');

var ERROR_MESSAGES = enums.ERROR_MESSAGES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/attributes_validator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* Provides utility method for validating that the attributes user has provided are valid
*/

var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var lodashForOwn = require('lodash/forOwn');

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/attributes_validator/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
var chai = require('chai');
var assert = chai.assert;
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var attributesValidator = require('./');

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/config_validator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
var MODULE_NAME = 'CONFIG_VALIDATOR';
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/config_validator/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
var chai = require('chai');
var assert = chai.assert;
var configValidator = require('./');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;

Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/event_tag_utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* Provides utility method for parsing event tag values
*/
var enums = require('../enums');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var LOG_LEVEL = enums.LOG_LEVEL;
var LOG_MESSAGES = enums.LOG_MESSAGES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/event_tags_validator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* Provides utility method for validating that event tags user has provided are valid
*/

var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
var MODULE_NAME = 'EVENT_TAGS_VALIDATOR';
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/event_tags_validator/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
var chai = require('chai');
var assert = chai.assert;
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var eventTagsValidator = require('./');

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/json_schema_validator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
var fns = require('../fns');
var validate = require('json-schema').validate;
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
var MODULE_NAME = 'JSON_SCHEMA_VALIDATOR';
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/json_schema_validator/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var chai = require('chai');
var assert = chai.assert;
var jsonSchemaValidator = require('./');
var projectConfigSchema = require('../../optimizely/project_config_schema');
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var testData = require('../../tests/test_data.js');

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/user_profile_service_validator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* Provides utility method for validating that the given user profile service implementation is valid.
*/

var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
var MODULE_NAME = 'USER_PROFILE_SERVICE_VALIDATOR';
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/utils/user_profile_service_validator/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

var chai = require('chai');
var assert = chai.assert;
var sprintf = require('sprintf');
var sprintf = require('sprintf-js').sprintf;
var userProfileServiceValidator = require('./');

var ERROR_MESSAGES = require('../enums').ERROR_MESSAGES;
Expand Down
20 changes: 11 additions & 9 deletions packages/optimizely-sdk/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/optimizely-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"json-schema": "^0.2.3",
"lodash": "^4.0.0",
"murmurhash": "0.0.2",
"sprintf": "^0.1.5",
"sprintf-js": "^1.1.1",
"uuid": "^3.0.1"
},
"devDependencies": {
Expand Down