feature(API): Adds input validation in all API methods and validates empty user Id. #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfahadahmed this needs to be accompanied by a PR to change up the failing Compat Suite test. Please check it out. |
|
build |
mikeproeng37
suggested changes
Nov 15, 2018
| @@ -334,7 +334,8 @@ Optimizely.prototype.getVariation = function(experimentKey, userId, attributes) | |||
| */ | |||
| Optimizely.prototype.setForcedVariation = function(experimentKey, userId, variationKey) { | |||
| try { | |||
| return projectConfig.setForcedVariation(this.configObj, experimentKey, userId, variationKey, this.logger); | |||
| return this.__validateInputs({ experiment_key: experimentKey, user_id: userId }) | |||
There was a problem hiding this comment.
very nitpicky: explicitily return false if !this.__validateInputs... and then keep the previous return value
| @@ -368,6 +373,16 @@ Optimizely.prototype.getForcedVariation = function(experimentKey, userId) { | |||
| */ | |||
| Optimizely.prototype.__validateInputs = function(stringInputs, userAttributes, eventTags) { | |||
| try { | |||
| // Empty user Id is valid value. | |||
There was a problem hiding this comment.
It's better to document what is NOT a valid value :)
mikeproeng37
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.