Skip to content

fix(tests): Update to latest karma to fix internalBinding bug. #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2018
Merged

fix(tests): Update to latest karma to fix internalBinding bug. #202

merged 2 commits into from
Dec 21, 2018

Conversation

mikeproeng37
Copy link
Contributor

Summary

  • Fixes issue with xbrowser test runs erroring out with the message: internalBinding is not defined

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.239% when pulling 962ff9e on mng/update-karma into a7c7121 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.239% when pulling 962ff9e on mng/update-karma into a7c7121 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.239% when pulling 962ff9e on mng/update-karma into a7c7121 on master.

@coveralls
Copy link

coveralls commented Dec 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.239% when pulling 9e31f7f on mng/update-karma into a7c7121 on master.

@mjc1283 mjc1283 self-requested a review December 20, 2018 23:53
@mikeproeng37 mikeproeng37 merged commit 2bf0d2c into master Dec 21, 2018
@mikeproeng37 mikeproeng37 deleted the mng/update-karma branch January 14, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeproeng37 @coveralls @mjc1283