Skip to content

refac(ci): switch stage order #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2018
Merged

refac(ci): switch stage order #203

merged 2 commits into from
Dec 21, 2018

Conversation

juancarlostong
Copy link
Contributor

Summary

  • switch the order of stages so that integration tests occur ahead of unit tests. this allows resetting the build status to pending without having to wait for unit tests to finish first.

mikeproeng37
mikeproeng37 suggested changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add documentation about the change in the code itself :D

@coveralls
Copy link

coveralls commented Dec 21, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.239% when pulling 9a5d975 on jctong/switch_stage_order into 2bf0d2c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.239% when pulling dba5174 on jctong/switch_stage_order into 2bf0d2c on master.

@juancarlostong juancarlostong force-pushed the jctong/switch_stage_order branch from dba5174 to 6e47b6a Compare December 21, 2018 00:24
@mikeproeng37 mikeproeng37 merged commit 3ea6be2 into master Dec 21, 2018
@mikeproeng37 mikeproeng37 deleted the jctong/switch_stage_order branch January 14, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancarlostong @coveralls @mikeproeng37