fix (unit tests): Fix event dispatcher missing in unit test #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2019 13:05
tests on unhandled promise rejections.
jordangarcia
approved these changes
Apr 8, 2019
| @@ -0,0 +1,7 @@ | |||
| process.on('unhandledRejection', function(err) { | |||
There was a problem hiding this comment.
Mind adding a comment in this explaining why this is here.
mikeproeng37
suggested changes
Apr 8, 2019
| @@ -0,0 +1,11 @@ | |||
| /* | |||
There was a problem hiding this comment.
Maybe we should move this into the lib dir and further, into the tests dir since this is only used for tests.
Also, please include the license header for this code file :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimizelywas constructed without an event dispatcher, causing an error to be thrown asynchronously. This fixes the test, and updates thenpm testcommand to make it easier to catch such mistakes - adding a listener for'unhandledRejection'onprocessthat callsprocess.exit.Test plan
Run unit tests, verify log output.