Skip to content

feat(event processor): Send log event notification upon event dispatch when notification center available #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 12, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Aug 8, 2019

Summary

With this change, the event processor can be constructed with a notification center. If a notification center is provided, it triggers a log event notification after the event is sent to the event dispatcher.

Test plan

Added new unit test. Manually tested

Issues

https://optimizely.atlassian.net/browse/OASIS-4976

@mjc1283 mjc1283 requested review from mikeproeng37 and a team August 8, 2019 21:44
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please rebase PR so we don't get changes from other PRs mixed in

@@ -38,7 +38,7 @@
},
"dependencies": {
"@optimizely/js-sdk-logging": "^0.1.0",
"@optimizely/js-sdk-utils": "^0.1.0"
"@optimizely/js-sdk-utils": "^0.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are not supposed to be in this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did intend this. I'm updating to 0.2.0 so I can get access to NOTIFICATION_TYPES and NotificationCenter, new exports from js-sdk-utils. But did you want this update itself to be separated into its own PR?

@mjc1283 mjc1283 requested a review from mikeproeng37 August 9, 2019 00:04
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mjc1283 mjc1283 merged commit 3398f89 into master Aug 12, 2019
@mjc1283 mjc1283 deleted the mcarroll/OASIS-4976-notification-center branch August 12, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants