fix(event processor): Flush current batch when event with different context received #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 9, 2019 11:09
…ext, flush as soon as a different context is observed
aliabbasrizvi
approved these changes
Aug 12, 2019
| flushInterval: 100, | ||
| maxQueueSize: 100, | ||
| sink: sinkFn, | ||
| batchComparator: (n1, n2) => (n1 % 2) === (n2 % 2) |
There was a problem hiding this comment.
nit. Can you add a comment about what this thing is doing? It will be useful for future maintainers.
There was a problem hiding this comment.
I changed it to a more straightforward test checking the first character of a string, and added comments.
| const conversionEvent = createConversionEvent() | ||
| const impressionEvent2 = createImpressionEvent() |
There was a problem hiding this comment.
nit. Can you add a note that createImpressionEvent and createConversionEvent create events with revision '1' and so line 300 makes sense with that context.
Or leave a comment for line 300 i.e. setting different revision to be able to test flush.
added 2 commits
August 13, 2019 08:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this change, event processor's buffer could contain events with different contexts. At flush time, the buffered events would be grouped by context and a request would be dispatched for each group.
With this change, we introduce an invariant: all events in the buffer share the same context. As soon as an event with different context is received, the queue is flushed. With this restriction, at most one request is dispatched per flush.
batchComparator) is provided toDefaultEventQueue. When enqueuing an event,batchComparatoris used to determine whether the incoming event can be included into the current batch. If not, we flush.LogTierV1EventProcessorprovides abatchComparatorwhen constructing aDefaultEventQueuethat checks equality of all context properties.AbstractEventProcessor, the grouping step is removed from the flush process.Test plan
New unit tests. Manually tested.
Issues
OASIS-5160